Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO and CoC (updated) #1229

Closed
wants to merge 2 commits into from
Closed

DCO and CoC (updated) #1229

wants to merge 2 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jun 12, 2017

Updated #771
lifted verbatim from
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
then /s/Node.js/node-gyp/

@refack
Copy link
Contributor Author

refack commented Jun 12, 2017

@refack refack changed the title Dco and coc (updated) DCO and CoC (updated) Jun 12, 2017
CONTRIBUTING.md Outdated

Please read the
[Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md)
which explains the minimum behavior expectations for Node.js contributors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe s/Node.js/node-gyp/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@gibfahn
Copy link
Member

gibfahn commented Jun 12, 2017

Where did this text come from? Might be worth including it in the commit message.

@refack
Copy link
Contributor Author

refack commented Jun 12, 2017

Where did this text come from? Might be worth including it in the commit message.

Ack

@refack refack self-assigned this Jun 12, 2017
gibfahn pushed a commit that referenced this pull request Jun 14, 2017
Lifted verbatim from
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
then `s/Node.js/node-gyp/`.

PR-URL: #1229
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Jun 14, 2017

Landed in 2e40fad

@gibfahn gibfahn closed this Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants